Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the init integration docs more obvious #784

Closed
wants to merge 1 commit into from
Closed

made the init integration docs more obvious #784

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2017

added example in shell

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@ghost ghost changed the title made the init integration more obvious made the init integration docs more obvious Apr 7, 2017
deployment's `/sysroot` to the physical `/`, and then finally uses
`mount(MS_MOVE)` to make the deployment root appear to be the root
filesystem before telling systemd to switch root.
OSTree comes with optional dracut+systemd integration code:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a space between this line and the one below, otherwise it's not going to render as a list.

- set up the read-only bind mount on `/usr`
- bind mount the deployment's `/sysroot` to the physical `/`
- use `mount(MS_MOVE)` to make the deployment root appear to be the
root filesystem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this got line wrapped?

support other initramfs technologies and init systems, if sufficiently
clean, will likely be accepted upstream.
possible, but you will have to write the integration code. E.g:
```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

but you will have to write the integration code. See the existing
sources in src/switchroot as a reference, as well as src/switchroot/switchroot.sh.

(And copy the code you have to src/switchroot/switchroot.sh)

?

This could help others who want to integrate with other init
systems/initramfs.

Commit-message-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Member

Thanks, I squashed these together, made a few minor tweaks, and updated the commit message.

@rh-atomic-bot r+ 00e3f8b

@rh-atomic-bot
Copy link

⌛ Testing commit 00e3f8b with merge dea2025...

@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: cgwalters
Pushing dea2025 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants